-
Notifications
You must be signed in to change notification settings - Fork 75
Add codeVariants to search issues rest api #103
base: master
Are you sure you want to change the base?
Add codeVariants to search issues rest api #103
Conversation
审核指南 by Sourcery此PR为SonarQube REST客户端的search_issues API函数添加了一个新的可选参数'codeVariants'。实现过程简单,保持了现有参数结构和文档风格的同时,将参数添加到函数签名中。 更新后的search_issues函数的类图classDiagram
class search_issues {
+assigned
+assignees
+author
+codeVariants
+createdAfter
+createdAt
+createdBefore
}
note for search_issues "在函数签名中添加了codeVariants参数"
文件级别的更改
提示和命令与Sourcery互动
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis PR adds a new optional parameter 'codeVariants' to the search_issues API function in the SonarQube REST client. The implementation is straightforward, adding the parameter to the function signature while maintaining the existing parameter structure and documentation style. Class diagram for updated search_issues functionclassDiagram
class search_issues {
+assigned
+assignees
+author
+codeVariants
+createdAfter
+createdAt
+createdBefore
}
note for search_issues "Added codeVariants parameter to the function signature"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗨 @vaskoandras - 我已经审查了你的更改 - 这里有一些反馈:
总体评论:
- 请增强
codeVariants
参数的文档,以解释在 SonarQube 的上下文中代码变体是什么,并可能包括一个使用示例。
这是我在审查期间查看的内容
- 🟢 一般问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English
Hey @vaskoandras - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please enhance the documentation for the
codeVariants
parameter to explain what code variants are in the context of SonarQube and possibly include a usage example.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Add codeVariants paramter to the api/issues/search api call
Summary by Sourcery
新功能:
Original summary in English
Summary by Sourcery
New Features: