-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sort dependencies #4
Conversation
Thanks for opening a PR 🍺 I'm still of the opinion that the solution in my comment on #2 would invariably be the most flexible solution for this. I don't believe the extra processing here is going to be necessary in most cases, and an option to specify additional property values to sort would cover the edge cases. |
At the end of the day, it's your plugin so I'm happy to go with your judgement. However my counter-argument would be that we're already being very opinionated with ordering and so why stop at high-level keys? Especially as |
That's precisely why I'm hesitant. The package managers all handle this. I'd argue the edge case here is manually adding dependencies out of order to those arrays. It's not something that most users are going to do, so processing those arrays isn't something we should do on every run. |
Right, gotcha. Yeah, maybe this isn't so useful. Feel free to close if this all seems like overkill. |
If you're up for it, I'd like to change this to provide that |
Sure. Will do... |
I had a go but couldn't figure out how to get the option to pass through to the plugin. |
OK let's keep this open. I'll follow up later today or tomorrow AM. |
OK so I'm not sure why this didn't automatically close, but your changes were merged in on 5df5f77. I chose to merge this as an intermediate step to the custom sort spec. |
So I've done the leg work for allowing custom sorting on the I need to give this some thought. We can't specify an |
Okay, thanks for looking into it. |
This PR contains:
Breaking Changes?
If users' dependencies are not alphabetically sorted, they will notice changes.
Please Describe Your Changes
Will alphabetically sort dependencies. Issue: #2