Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): remove forward refs, adjust types, change imports in demos #8

Merged

Conversation

devjmetivier
Copy link
Contributor

Component / Package Name: N/A

Note: Would make sure that no distinguishable changes can be seen in the demo. None to my eyes, but can't hurt to double check.

Key takeaways:

  • Remove unnecessary use of React.forwardRef
  • Change @jsx-email/components imports to @jsx-email/all
  • Reduce React import to typed imports where possible (although I don't think this will provide a library benefit seeing as react is only listed as a peer dependency in each package)

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

@shellscape shellscape changed the title remove forward refs, adjust types, change imports in demos chore(repo): remove forward refs, adjust types, change imports in demos Sep 27, 2023
@lordelogos lordelogos merged commit 67d3569 into shellscape:main Sep 27, 2023
2 checks passed
@devjmetivier devjmetivier deleted the devjmetivier/remove-forward-refs branch September 27, 2023 13:58
@lordelogos
Copy link
Collaborator

Thank you @devjmetivier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants