Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding otp validation support #202

Merged
merged 10 commits into from
Mar 9, 2024
Merged

feat: adding otp validation support #202

merged 10 commits into from
Mar 9, 2024

Conversation

shawakash
Copy link
Owner

@shawakash incompleted issue #201

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2024

⚠️ No Changeset found

Latest commit: fb5bf7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
pay-box-web ❌ Failed (Inspect) Mar 9, 2024 1:30pm

@shawakash shawakash self-assigned this Mar 9, 2024
@shawakash shawakash merged commit e56efcf into dev Mar 9, 2024
6 of 15 checks passed
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 9, 2024
View reviewed changes
packages/common/src/validations/clientValid.ts
name: z
.string()
.regex(
/^[A-Za-z]+([- ]?[A-Za-z]+)*$/,

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with 'A' and containing many repetitions of 'A'.
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 9, 2024
View reviewed changes
backend/api/src/auth/middleware.ts
status: responseStatus.Error,
msg: "Too many requests, please try again after 15 minutes"
},
keyGenerator: function (req, res) {

Check warning

Code scanning / ESLint

disallow unused variables Warning

'res' is defined but never used.
backend/api/src/auth/util.ts
@@ -1,4 +1,4 @@
import type { Request, Response } from "express";
import { response, type Request, type Response } from "express";

Check warning

Code scanning / ESLint

disallow unused variables Warning

'response' is defined but never used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shawakash shawakash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shawakash