555 Timer's reset pin is active low, so should have bar over name #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Active low pins typically use a naming convention that puts a bar over the name. For the most part, datasheets and wikipedia.org/wiki/555_timer_IC have a bar over the reset pin name. Circuitjs already puts a bar over the 555's trigger pin, so the reset pin should also have a bar.
|
Separate but related: I would also suggest that the pin currently named "Vin" should be renamed to "Vcc" as per typical naming of voltage supply pins and usage in 555 datasheets and 555's wikipedia page currently. "Vin" is also a little ambiguous (cause all 555 pins except the output and discharge could hypothetically be considered to be input pins). I didn't put it in this PR to keep this PR simple, but I would just suggest you consider also replacing instances of the string "N_VIN" with "N_VCC" and the string "Vin" with "Vcc" in this file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active low pins typically use a naming convention that puts a bar over the name. For the most part, datasheets and wikipedia.org/wiki/555_timer_IC have a bar over the reset pin name. Circuitjs already puts a bar over the 555's trigger pin, so the reset pin should also have a bar.