Apply a formatting pass across the repository #98
+27,719
−25,308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glitch18
force-pushed
the
refac/repoFormattingPass
branch
from
e817545 to
c1bdae4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } else { | ||
| if (logFlags.console) console.log(`Data recipient ${publicKey} is already removed`) | ||
| if (logFlags.console) console.log(`Data recipient ${publicKey} is already removed`); |
Check warning
Code scanning / CodeQL
Log injection Medium
| } | ||
|
|
||
| export function addArchiverConnection(publicKey, socketId) { | ||
| connectedSockets[publicKey] = socketId | ||
| connectedSockets[publicKey] = socketId; |
Check failure
Code scanning / CodeQL
Remote property injection High
| } | ||
| delete connectedSockets[publicKey] | ||
| delete connectedSockets[publicKey]; |
Check failure
Code scanning / CodeQL
Remote property injection High
Glitch18
force-pushed
the
refac/repoFormattingPass
branch
from
e395bf1 to
b8b838d
Compare
Glitch18
force-pushed
the
refac/repoFormattingPass
branch
from
b8b838d to
5384077
Compare
jairajdev
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while now, a majority of the files in the repo were unformatted. This resutled in large modifications being done to the files during development because of the format on save setting. This was prompting developers to disable the setting and push features and changes upstream without standardized prettier formatting, thus resulting in more unformatted files.
This PR runs a prettier format across the repository
npx prettier --write .According to
.prettierignorefolders likedist,buildandtestare excludedMerging this should give us a formatted repo and we can re-enable our format on save settings to ensure formatting is maintained in all further commits