SHARD-1167 #341
Draft
SHARD-1167 #341
+135
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a configurable node age calculation system that allows applications to influence node rotation decisions. Key changes include: - Add NodeRotation.ts with interfaces for custom age calculation - Modify NodeList.ts to use effective age for rotation ordering - Add comprehensive logging and monitoring for: - Age calculation performance - State inconsistencies - Sorting anomalies - Error conditions The implementation is designed to: - Maintain backward compatibility - Provide detailed debugging information - Fail gracefully to actual age on errors - Use deterministic sorting with node ID tiebreaker Testing Notes: - Monitor logs for age-inversion and near-equal-ages events - Watch for slow-age-calculation warnings - Track sudden-age-change frequency BREAKING CHANGE: Node rotation order may change if custom age calculation is enabled by the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.