Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RED-103: use nodelistFromStates function in all cycle tx sendGossip calls #253

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

RED-103: use nodelistFromStates function in all cycle tx sendGossip calls #253

wants to merge 11 commits into from
+261 −57

Conversation

mhanson-github
Copy link
Contributor

New PR for this bug.

@mhanson-github mhanson-github changed the title RED-103: nodeListFromStates RED-103: use nodeListFromStates function in all cycle tx sendGossip calls Aug 21, 2024
@dnlbui
Copy link
Contributor

dnlbui commented Aug 21, 2024

Ready for review. Rebased and added a two commits to address mistakes (8ffe854 and 8dde130

ahmxdiqbal
ahmxdiqbal reviewed Aug 21, 2024
View reviewed changes
src/p2p/Join/routes.ts Outdated Show resolved Hide resolved
@dnlbui dnlbui changed the title RED-103: use nodeListFromStates function in all cycle tx sendGossip calls RED-103: use nodelistFromStates function in all cycle tx sendGossip calls Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmxdiqbal ahmxdiqbal ahmxdiqbal left review comments

@dnlbui dnlbui dnlbui left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhanson-github @dnlbui @ahmxdiqbal