Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nix flake to pin Node and Rust versions #247

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

muni-corn
Copy link
Contributor

Pins nixpkgs, Node (18.16.1), and Rust (1.74.1) to versions compatible with this repository.

nixpkgs is pinned to an older version for Node v18 to build without failure.

Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Hardcoded SHA256
The SHA256 hashes for Node.js and Rust are hardcoded in the flake file. This might lead to potential build failures if the packages at these hashes are removed or corrupted in the future. Consider a more dynamic approach to handle dependencies.

Dependency Management
The PR introduces new dependencies (fenix, nixpkgs-node-18) without removing or updating existing dependencies. Ensure that all dependencies are necessary and maintained to avoid security vulnerabilities and package conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant