RED-201: Network Generated Transactions #240
Open
+991
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tting the previous records
…w fields to db. Expose new functions in shardus to allow for adding network transactions and verifiers.Minor cleanup of unused logs
…lidation for this. Do not add tx that has already been added to txadd
…to txList and implement reset function
…nd verify in handler
* move module functions around * organize ServiceQueue module around existing module structure * add syncTxListFromArchiver func * chore: lint ServiceQueue * chore: move variables above routes * switch to using random archiver for syncing tx list * add syncing tx list step to restore callback * remove unused import * add await to sync tx list func call ;)
code clean up
chore: Add debug flag for NTP bogus offset decrements chore: Update time synchronization error messages and comment debug endpoint chore: Remove commented debug endpoint for NTP bogus offset decrements
Bumps the npm_and_yarn group with 4 updates in the / directory: [express](https://github.com/expressjs/express), [socket.io](https://github.com/socketio/socket.io), [braces](https://github.com/micromatch/braces) and [tar](https://github.com/isaacs/node-tar). Updates `express` from 4.16.4 to 4.19.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.16.4...4.19.2) Updates `socket.io` from 2.4.1 to 2.5.0 - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md) - [Commits](socketio/socket.io@2.4.1...2.5.0) Updates `braces` from 3.0.2 to 3.0.3 - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) Updates `tar` from 6.1.15 to 6.2.1 - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.1.15...v6.2.1) --- updated-dependencies: - dependency-name: express dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: socket.io dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: braces dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: tar dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]>
fix: add logging to 404 case in dumpTree
remove comments
…tion on fetchLatestCycle
Make safetyNum optional
…ameters and payload) (#255) * feat: adding replay attack protection for debug endpoints' payloads * chore : formatting
afostr
force-pushed
the
serviceQueue-impl
branch
from
82f6011 to
e830dd0
Compare
afostr
reviewed
Sep 11, 2024
| // get latest entry for node in txList. and if it is init then we inject otherwise continue | ||
| // first iterate over txlist backwards and get first entry that has public key of node | ||
| const txListEntry = reversedTxList.find((entry) => entry.tx.txData.publicKey === node.publicKey) | ||
| if (txListEntry && txListEntry.tx.type !== 'nodeInitReward') { |
There was a problem hiding this comment.
Taking this as techdebt. We should replace with app.getFinalNodeTXName() an similar functions so that the final TX names, shape and creation come from the app
There was a problem hiding this comment.
This is being refactored by Phillipp as this shouldn’t be in the shardus layer but rather in the app layer
There was a problem hiding this comment.
All the shutdown impl in update record is going to be changed when he pushes that tomorrow
afostr
reviewed
Sep 11, 2024
| @@ -1742,6 +1763,19 @@ class Shardus extends EventEmitter { | |||
| return latestCycle ? latestCycle.active : 0 | |||
| } | |||
|
|
|||
| fastIsPicked(numberToPick: number) { | |||
There was a problem hiding this comment.
did we need to cut and paste this?
There was a problem hiding this comment.
oh, I see it is wrapping and for nodes. A modified name would be nice. fastIsPickedActiveNodes or similar
ahmxdiqbal
reviewed
Sep 11, 2024
Comment on lines
+749
to
+751
| txadd: [], | ||
| txremove: [], | ||
| txlisthash: '', |
There was a problem hiding this comment.
i think we should be using camel case for cycle record fields. thats the pattern for all other fields in the cycle record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.