Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send node version while joining as a first node during restart #235

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Send node version while joining as a first node during restart #235

wants to merge 1 commit into from
+5 −1

Conversation

tanuj-shardeum
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Import Conflict
The import of version from 'os' on line 37 might conflict with the import of version as shardusVersion from '../../package.json' on line 2. Consider renaming one of them for clarity.

Code Redundancy
The version import from 'os' on line 37 does not seem to be used anywhere in the provided code changes. If it's not needed, consider removing this import to keep the code clean and maintainable.

@tanuj-shardeum tanuj-shardeum marked this pull request as ready for review September 24, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jairajdev jairajdev Awaiting requested review from jairajdev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Review effort [1-5]: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tanuj-shardeum