SEC-421: Binary Handler Impersonation Check

src/network/index.ts

@@ -127,6 +127,19 @@ export class NetworkClass extends EventEmitter {
     next()
   }
 
+  handleError(error: any, req: any, res: any, route: string) {
+    /* prettier-ignore */ if (logFlags.error) this.mainLogger.error(`Error in route ${route}: ${error.message}`)
+
+    nestedCountersInstance.countEvent('endpoint-exception', `${route}`)
+
+    // Send an error response
+    res.status(500).json({
+      error: 'Internal Server Error',
+      message: isDebugMode() ? error.message : 'An unexpected error occurred',
+      route: route,
+    })
+  }
+
   // TODO: Allow for binding to a specified network interface
   _setupExternal() {
     return new Promise((resolve, reject) => {
@@ -545,29 +558,29 @@ export class NetworkClass extends EventEmitter {
       handlers.push(authHandler)
     }
 
-    if (isDebugMode() && ['GET', 'POST'].includes(method)) {
-      const wrappedHandler = async (req, res, next) => {
-        profilerInstance.profileSectionStart('net-externl', false)
-        profilerInstance.profileSectionStart(`net-externl-${route}`, false)
-        profilerInstance.scopedProfileSectionStart(`net-externl-${route}`, false)
-
-        let result
-        try {
-          result = await responseHandler(req, res, next)
-        } finally {
+    const wrappedHandler = async (req, res, next) => {
+      let result
+      try {
+        if (isDebugMode() && ['GET', 'POST'].includes(method)) {
+          profilerInstance.profileSectionStart('net-externl', false)
+          profilerInstance.profileSectionStart(`net-externl-${route}`, false)
+          profilerInstance.scopedProfileSectionStart(`net-externl-${route}`, false)
+        }
+        result = await responseHandler(req, res, next)
+      } catch (error) {
+        this.handleError(error, req, res, route)
+      } finally {
+        if (isDebugMode() && ['GET', 'POST'].includes(method)) {
           profilerInstance.scopedProfileSectionEnd(`net-externl-${route}`)
           profilerInstance.profileSectionEnd(`net-externl-${route}`, false)
           profilerInstance.profileSectionEnd('net-externl', false)
         }
-
-        return result
       }
-
-      handlers.push(wrappedHandler)
-    } else {
-      handlers.push(responseHandler)
+      return result
     }
 
+    handlers.push(wrappedHandler)
+
     let expressMethod = {
       GET: 'get',
       POST: 'post',

src/p2p/Comms.ts

@@ -639,7 +639,12 @@ export function registerInternalBinary(route: string, handler: InternalBinaryHan
       warn('registerInternalBinary: internal routes can only be used by nodes in the network...')
       return
     }
-
+    if (
+      NodeList.nodes.get(header.sender_id).publicKey !== sign.owner
+    ) {
+      warn('registerInternalBinary: Public key is not the same with sign owner')
+      return
+    }
     // Checks to see if we can extract the actual payload from the wrapped message
     const requestPayload = _extractPayloadBinary(wrappedPayload)
     if (!requestPayload) {