SHARD-1147: Improve Blacklisting Consistency and Optimize Check Intervals #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S0naliThakur
requested review from
aniketdivekar,
BelfordZ,
jintukumardas,
abdulazeem-tk4vr and
devendra-shardeum
abdulazeem-tk4vr
previously approved these changes
Dec 6, 2024
S0naliThakur
dismissed stale reviews from abdulazeem-tk4vr and devendra-shardeum
via
a94e33c
abdulazeem-tk4vr
previously approved these changes
Dec 6, 2024
…sync unbans, ensure consistency, and enhance error handling.
S0naliThakur
changed the title
src/utils.ts
Outdated
Comment on lines
696
to
702
| if (verifyData.length !== this.bannedIps.length) { | ||
| if (verbose) console.log('Warning: Inconsistency detected between bannedIps and blacklist.json') | ||
| // Ensure bannedIps matches the file | ||
| this.bannedIps = verifyData.map((ip: string) => ({ | ||
| ip, | ||
| timestamp: Date.now(), | ||
| })) |
There was a problem hiding this comment.
why is this block needed? if this is to handle race condition, then this verification doesn't solve the issue. because verifyData.length !== this.bannedIps.length can be true but content of both arrays can be different.
There was a problem hiding this comment.
I added the check to keep the blacklist.json data consistent with the in-memory blacklist IP map. I've now updated it so that if there's any inconsistency, it prioritizes the in-memory map.
aniketdivekar
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear: https://linear.app/shm/issue/SHARD-1147
Summary: