Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont count localhost for ratelimit #94

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: dont count localhost for ratelimit #94

wants to merge 1 commit into from

Conversation

BelfordZ
Copy link
Contributor

@BelfordZ BelfordZ commented Dec 5, 2024

No description provided.

@devendra-shardeum devendra-shardeum self-requested a review December 6, 2024 06:24
devendra-shardeum
devendra-shardeum requested changes Dec 6, 2024
View reviewed changes
Copy link

@devendra-shardeum devendra-shardeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localhost ips which we want to let pass.. should be coming from whitelist file only.. so i don't want this pr to be merged.. no hardcoded ips inside the middleware.. looks bad to me..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devendra-shardeum devendra-shardeum devendra-shardeum requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BelfordZ @devendra-shardeum