Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor-fix: lost-archiver refute logic #26

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

tanuj-shardeum
Copy link
Contributor

No description provided.

Copy link

linear bot commented May 22, 2024

BLUE-21 Bug when submitting the lost archiver refute request, causing a fatal error due to undefined properties in the update record function.

!channel, I found a way to take down active node, due to fake lost archiver message.
It worked for both release mode and debug mode but have to be an active node.

The request:

POST /lost-archiver-refute HTTP/1.1
Content-Type: application/json
Accept: **/**
Content-Length: 117
User-Agent: node-fetch/1.0 (+h
<ttps://github.com/bitinn/node-fetch>)
Accept-Encoding: gzip,deflate
Host: 127.0.0.1:9021
Connection: close

{"archiver":"testarchiver","cycle":"00000000000000000000000000000000","sign":{"owner":"justatest","sig":"justatest"}}

The node will procced the request if it is included the sign object with owner and sig.
In the new cycle, node will crash due to the archiver is not totally existed.
Here is the log message from node.

                                                                                                                                                                                                           [2024-02-05T10:46:18.150] [FATAL] fatal - unhandledRejection: TypeError: Cannot read properties of undefined (reading 'investigateMsg')                                                                                                        at Object.updateRecord (/home/shardeumcoredev/server/node_modules/shardus/src/p2p/LostArchivers/index.ts:126:47)                                                                                                                          at /home/shardeumcoredev/server/node_modules/shardu...

image.png

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants