-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: inverse rate when clicked #9002
feat: inverse rate when clicked #9002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @presstab! Some comments below.
In addition, we'll want to ensure the rate text is not highlightable on click:

gm @presstab Thanks a lot for the contrib! I wasn't intended to front run your PR but I definitely had to implement this bit in the limit order PR considering that #8970 would have changed a lot of your logic, which was also invalidating some reviews you already fixed... I've been pragmatic and avoided more back and forth because of my work (mainly due to automatic side changes depending on limit order discriminator asset). ![]() ![]() So, this PR can be closed as it's implemented now! |
Description
It is an industry standard for swappers to be able to inverse a quoted rate to switch the denomination back and forth between basecoin and quotecoin.
For example by default, when I am trading USDC -> FOX, the app displays: 1 USDC = XXX FOX. This is not very helpful, as almost all exchanges will default to denominating a rate in terms of fiat. I need a calculator to actually see the fiat rate that I get.
Clicking on the rate should swap the perspective and show 1 FOX = XXX USDC, which is the human readable form of the quote.
Issue (if applicable)
closes #9001
Risk
Low
Testing
Engineering
Operations
Screenshots