fix: update thorfi warning copy and remove discord link#8860
Merged
fix: update thorfi warning copy and remove discord link#8860
Conversation
Contributor
|
Invalidated the translations, so we don't present a different messaging to our non-English users regarding the time period. |
gomesalexandre
approved these changes
Feb 17, 2025
Contributor
gomesalexandre
left a comment
gomesalexandre
left a comment
There was a problem hiding this comment.
Tested locally, LGTM!
https://jam.dev/c/07cc74f1-5009-4018-80b4-dd53c61c4423
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make thorfi copy more general, without time period
Remove the discord link, to remove the risk of a phishing attack, waiting for a permalink
Issue (if applicable)
closes #8669
Risk
Testing
Engineering
n/a
Operations
n/a
Screenshots (if applicable)