Skip to content

fix: thorfi halted warning copies and improvements#8681

Merged
NeOMakinG merged 6 commits intodevelopfrom
lending-infos
Jan 29, 2025
Merged

fix: thorfi halted warning copies and improvements#8681
NeOMakinG merged 6 commits intodevelopfrom
lending-infos

Conversation

@NeOMakinG
Copy link
Collaborator

@NeOMakinG NeOMakinG commented Jan 28, 2025

Description

Does exactly what the ticket says:

  • Move lending down to the menu
  • Add warning in lending page + saver modal
  • Remove thorchain savers from carrousel and sliders
  • Changed lending pool depth to status and showing Halted if both flags are disabled
  • Removed thorchain defi form markets page

Issue (if applicable)

closes #8669

Risk

Low

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Check that warning are shown in lending page and savers modals overview
  • Try to click on the discord link
  • Check that savers are not shown anymore in Earn's page carrousel and in any asset page sliders

Engineering

n/a

Operations

n/a

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

image
image

Also added to runepool as informational (@shapeshift/product do we really want? as runepool is currently on?)
image

image
image

@NeOMakinG NeOMakinG marked this pull request as ready for review January 29, 2025 09:39
@NeOMakinG NeOMakinG requested a review from a team as a code owner January 29, 2025 09:39
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View-layer looks good, but a few things here:

  • Halted should display for savers only, not RUNEPool which isn't currently disabled. As far as RUNEPool goes, we can handle it the same way as savers by leveraging the RUNEPOOLENABLED mimir
  • Savers should be handled ideally using a mimir (PAUSELOANS since the savers situation is directly related to lending, though that may be a stretch...) or at the very least a feature flag
  • Similarly, lending halt states should be handled specifically as opposed to us having it disabled by leveraging the PAUSELOANS mimir

Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NeOMakinG NeOMakinG enabled auto-merge (squash) January 29, 2025 18:18
@NeOMakinG NeOMakinG merged commit 672a058 into develop Jan 29, 2025
3 checks passed
@NeOMakinG NeOMakinG deleted the lending-infos branch January 29, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thorfi Copy and explanations

2 participants