fix: thorfi halted warning copies and improvements#8681
Merged
Conversation
gomesalexandre
requested changes
Jan 29, 2025
Contributor
gomesalexandre
left a comment
There was a problem hiding this comment.
View-layer looks good, but a few things here:
- Halted should display for savers only, not RUNEPool which isn't currently disabled. As far as RUNEPool goes, we can handle it the same way as savers by leveraging the
RUNEPOOLENABLEDmimir - Savers should be handled ideally using a mimir (
PAUSELOANSsince the savers situation is directly related to lending, though that may be a stretch...) or at the very least a feature flag - Similarly, lending halt states should be handled specifically as opposed to us having it disabled by leveraging the
PAUSELOANSmimir
a0378b3 to
59f35c1
Compare
...ders/thorchain-savers/components/ThorchainSaversManager/Overview/ThorchainSaversOverview.tsx
Outdated
Show resolved
Hide resolved
gomesalexandre
approved these changes
Jan 29, 2025
Contributor
gomesalexandre
left a comment
There was a problem hiding this comment.
Retested locally, LGTM!
090206b to
6ca41ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Does exactly what the ticket says:
Issue (if applicable)
closes #8669
Risk
Low
Testing
Engineering
n/a
Operations
n/a
Screenshots (if applicable)
Also added to runepool as informational (@shapeshift/product do we really want? as runepool is currently on?)
