Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new wallet flow go live #8655

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 23, 2025

Description

Here goes nothing. This PR makes us go live with the new wallet flow.

Issue (if applicable)

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Medium - see testing notes.

Testing

Perform a full regression test of all wallets:

  • MM
  • Coinbase
  • Phantom (Solana + EVM + BTC)
  • Keplr (Cosmos only)
  • Native (import/create/switch)
  • Ledger
  • KK

⚠️ If you see bugs related to CTRL pairing getting the wrong address, this is a them issue, and doesn't happen with our app only but with every dApp. See:

https://discord.com/channels/554694662431178782/1331595048009203712/1331614131991744522

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

  • MM

https://jam.dev/c/f6ab324c-72b7-41d0-a979-5011c70998a2

  • Coinbase

https://jam.dev/c/a4b742d3-4887-4811-a792-3e89a990db75

https://jam.dev/c/62966e32-a56e-499d-841e-0a361254ccc1

  • Native (import/create/switch)

https://jam.dev/c/138a3410-1520-4ca5-b15c-e4913659cf44

  • Ledger

https://jam.dev/c/8d6abc1f-17fa-4db3-8f25-17bf149930b9

  • KK

https://jam.dev/c/509180b0-b7ba-455f-bf15-0f1c73259de6

@gomesalexandre gomesalexandre marked this pull request as ready for review January 23, 2025 18:46
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 23, 2025 18:46
@NeOMakinG NeOMakinG self-requested a review January 24, 2025 14:24
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native ✅ , MM ✅ , Rabby ❌

https://jam.dev/c/b9b1c5f1-62f7-4ea2-bfe8-13bb66405a4c
https://jam.dev/c/c91b6be6-2f16-4d04-8ba2-495184462f73

Rabby doesn't work, there are some errors in the console, but I've been able to use it on another browser:
image

I suspect some kind of conflicting cache from my extensions somehow

Ledger

https://jam.dev/c/177925c5-3280-4ac8-af89-40af1dd185db

Keepkey

https://jam.dev/c/843341b9-a045-4880-8c9d-34d090a2a27a

Wallet connect

Tested it on develop already

Phantom

https://jam.dev/c/93524527-c974-41a1-ad67-d3469c65b202
https://jam.dev/c/38b613ad-7a4e-4963-a5eb-0e1b54764991
I've no BTC on phantom so... leaving to ops

Coinbase

image I've been able to sign an approval, discovery is fine etc

Keplr

image I've no cosmos available, assuming it's fine looking at your test and ops should perfor ma full regression test

Looks good so far!

@NeOMakinG NeOMakinG enabled auto-merge (squash) January 24, 2025 15:31
@NeOMakinG NeOMakinG merged commit b3ef25a into develop Jan 24, 2025
3 checks passed
@NeOMakinG NeOMakinG deleted the feat_new_wallet_flow_all_envs branch January 24, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New wallet connection flow
2 participants