Skip to content

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 21, 2025

Description

Precisely what it says on the box.

Issue (if applicable)

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low/None

Testing

Engineering

  • Run with the mobile app set to localhost, or deploy me on your env (not gome as it will be used for final new wallet flow testing) and ensure the current wallet flow is used on mobile

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

None

Screenshots (if applicable)

image

@gomesalexandre gomesalexandre requested a review from a team as a code owner January 21, 2025 21:25
@0xApotheosis 0xApotheosis self-assigned this Jan 21, 2025
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local happy on web, just-deployed juice happy on mobile 👌

@0xApotheosis 0xApotheosis merged commit 39f5cdf into develop Jan 21, 2025
7 checks passed
@0xApotheosis 0xApotheosis deleted the feat_new_wallet_flow_disable_mobile_app branch January 21, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants