Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable limit order flag in base config #8602

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix: enable limit order flag in base config #8602

merged 1 commit into from
Jan 16, 2025
+1 −2

Conversation

0xApotheosis
Copy link
Member

Description

Fixed the limit order config by enabling it in .env.base instead of .env.app so it propagates to private, develop etc.

Issue (if applicable)

N/A

Risk

Small

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

N/A

Testing

N/A

Engineering

N/A

Operations

N/A

Screenshots (if applicable)

N/A

@0xApotheosis 0xApotheosis requested a review from a team as a code owner January 16, 2025 07:36
NeOMakinG
NeOMakinG approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get this in!

@NeOMakinG NeOMakinG merged commit 19e4089 into develop Jan 16, 2025
3 checks passed
@NeOMakinG NeOMakinG deleted the fix-limit-order-flag branch January 16, 2025 08:18
@gomesalexandre gomesalexandre mentioned this pull request Jan 16, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xApotheosis @NeOMakinG