Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cleanup useTradeNetworkFeeCryptoBaseUnit #8579

Merged
merged 1 commit into from
Jan 15, 2025
Merged

feat: cleanup useTradeNetworkFeeCryptoBaseUnit #8579

merged 1 commit into from
Jan 15, 2025
+26 −26

Conversation

gomesalexandre
Copy link
Contributor

Description

Tackles this guy #8570 (review):

Suggestion: Architecturally I'd prefer to see this logic in components/MultiHopTrade/components/TradeConfirm/TradeConfirmFooter.tsx and passed down in the enabled prop of useTradeNetworkFeeCryptoBaseUnit so that the useTradeNetworkFeeCryptoBaseUnit hook doesn't concern itself with the current state.

Issue (if applicable)

closes N/A

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low - same logic, but now passed from the parent.

Testing

  • Network fees should still stop fetching after sign and broadcast has been clicked

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

https://jam.dev/c/39d2fc16-becc-4b89-85ea-d14192fa664f

@gomesalexandre gomesalexandre marked this pull request as ready for review January 14, 2025 22:36
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 14, 2025 22:36
0xApotheosis
0xApotheosis approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this one ser!

@0xApotheosis 0xApotheosis merged commit 53c6e6b into develop Jan 15, 2025
3 checks passed
@0xApotheosis 0xApotheosis deleted the feat_useTradeNetworkFeeCryptoBaseUnit_cleanup branch January 15, 2025 00:25
@NeOMakinG NeOMakinG mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomesalexandre @0xApotheosis