Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: popular assets by market cap desc #8571

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 14, 2025

Description

Changes heuristics so that:

  1. We display 6 quick-list popular assets instead of 1
  2. The popular assets query used uses the market_cap_desc coingecko filter instead of volume_desc previously

Issue (if applicable)

closes #8141

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low

Testing

  • The popular asset quick-list is a 6-count of Coingecko's assets sorted by market cap desc (i.e, the homepage of cg, which uses market cap desc as a default criteria).
  • Scrolling down from "My Assets" to "Popular Assets" also displays a sane list when comparing against cg

Note 1: the list may look slightly different depending on wallet support e.g Solana or non-EVM chains support
Note 2: BNB duplicates (or others) across chains are expected, as related assets are currently borked

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

  • Quick-access list
Screenshot 2025-01-14 at 15 55 22 Screenshot 2025-01-14 at 15 55 36
  • "Popular Assets" section

https://jam.dev/c/31d83cc0-a37d-44b7-b93d-66c43546fec3

@gomesalexandre gomesalexandre requested a review from a team as a code owner January 14, 2025 15:09
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝

Screenshot 2025-01-15 at 12 12 26

@0xApotheosis 0xApotheosis merged commit 6afc9d3 into develop Jan 15, 2025
3 checks passed
@0xApotheosis 0xApotheosis deleted the feat_popular_assets_market_cap_desc branch January 15, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinned assets in asset selector in swapper
2 participants