Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: thor swapper simplify status detection #8567

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 14, 2025

Description

i.e instead of letting the API say we're done, assume done as soon as out Tx is seen (meaning it hit the mempool, and we have updated balances accordingly in app)

Issue (if applicable)

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low

Testing

  • Confirm THOR status detection is still happy, and as soon as you can see the out Tx, swapper goes to trade confirmed state
  • Confirm status detection of swaps to ROON are still happy

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

Non-ROON out

https://jam.dev/c/85ffba07-e940-4566-8fd6-de349fd7bf4d

ROON out

https://jam.dev/c/ef690eb4-da39-4583-beb1-fddf54087e7c

@gomesalexandre gomesalexandre marked this pull request as ready for review January 14, 2025 12:59
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 14, 2025 12:59
Copy link
Member

@woodenfurniture woodenfurniture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧠 Works goodly

@woodenfurniture woodenfurniture enabled auto-merge (squash) January 14, 2025 22:16
@woodenfurniture woodenfurniture merged commit 6bcfa23 into develop Jan 14, 2025
3 checks passed
@woodenfurniture woodenfurniture deleted the feat_thor_improve_cleanup_status_detection branch January 14, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants