Skip to content

fix: limit order never keep stale values for buy asset market price #8456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: limit order never keep stale values for buy asset market price #8456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/components/MultiHopTrade/components/LimitOrder/components/LimitOrderInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,8 @@ export const LimitOrderInput = ({
} = useQuoteLimitOrderQuery(limitOrderQuoteParams)

const marketPriceBuyAsset = useMemo(() => {
// Ensure we zero out the price if there is an error, and when we are fetching, as `quoteResponse` will be stale data in both cases
if (isLimitOrderQuoteFetching || quoteResponseError) return '0'
// RTK query returns stale data when `skipToken` is used, so we need to handle that case here.
if (!quoteResponse || limitOrderQuoteParams === skipToken) return '0'

Expand All @@ -227,7 +229,14 @@ export const LimitOrderInput = ({
sellAsset,
buyAsset,
})
}, [quoteResponse, limitOrderQuoteParams, sellAsset, buyAsset])
}, [
isLimitOrderQuoteFetching,
quoteResponseError,
quoteResponse,
limitOrderQuoteParams,
sellAsset,
buyAsset,
])

// Update the limit price when the market price changes.
useEffect(() => {
Expand Down