-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rfox for lpoors #8455
feat: rfox for lpoors #8455
Conversation
WIP PR for CLI tooling update and IPFS metadata updates - shapeshift/rFOX#95 |
82214f9
to
ab46a12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://jam.dev/c/355032fe-3c5f-46dc-9b74-b6025ae6edf4
I did a full test again, minus claim LP token, minus bridges (don't have enough funds and it costs a lot, will leave to ops)
One blocking comment thought, that we should tackle, I think doing a migration might be the proper solution as type-wise stakingContract
is supposed to be defined in the TX
packages/caip/src/adapters/coincap/generated/eip155_1/adapter.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolute monster of a PR. Left a very few comments, but overall looks conceptually perf 🐐
Runtime test ongoing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally:
Misc
- New dashboard is looking good (tested against develop - right)
WETH/FOX ARB LP ✅
RFOX stake flow e2e
https://jam.dev/c/f6934da5-5d26-47f8-83d5-51eb22f477d3
FOX ✅
Stake flow e2e regression test
https://jam.dev/c/39b34310-d113-4cba-9890-282894cc9ee6
Description
stakeAssetId
orselectedAssetId
depending if the selected asset it is the fox on ETHIssue (if applicable)
closes #7911
Risk
Let's say high, funds could be at risk somehow, sending to the wrong address
Testing
Engineering
n/a
Operations
n/a
Screenshots (if applicable)