Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rfox for lpoors #8455

Merged
merged 25 commits into from
Jan 16, 2025
Merged

feat: rfox for lpoors #8455

merged 25 commits into from
Jan 16, 2025

Conversation

NeOMakinG
Copy link
Collaborator

@NeOMakinG NeOMakinG commented Jan 3, 2025

Description

  • Pass assetId to every hooks needed to support another assetId
  • Use stakeAssetId or selectedAssetId depending if the selected asset it is the fox on ETH
  • Upgrade a bit the keys invalidation so we invalidate queries for every kind of contracts
  • Add market data fetch for the LP token
  • Change claims to support multiple contracts addresses
  • Add a small helper to select the right contract addy depending on the assetId

⚠️ Also blocked by the IPFS data thing, we need to handle both contracts now

Issue (if applicable)

closes #7911

Risk

Let's say high, funds could be at risk somehow, sending to the wrong address

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Try to stake, unstake, claim and change address for the LP pair
  • Also try to stake unstake claim and change address for the FOX token
  • Do the same with multi account

Engineering

n/a

Operations

n/a

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

image
image
image
image
image
image
image

@0xean
Copy link
Contributor

0xean commented Jan 6, 2025

WIP PR for CLI tooling update and IPFS metadata updates - shapeshift/rFOX#95

@kaladinlight kaladinlight changed the title [wip] feat: rfox for lpoors feat: rfox for lpoors Jan 15, 2025
@kaladinlight kaladinlight marked this pull request as ready for review January 15, 2025 01:45
@kaladinlight kaladinlight requested a review from a team as a code owner January 15, 2025 01:45
Copy link
Collaborator Author

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://jam.dev/c/355032fe-3c5f-46dc-9b74-b6025ae6edf4

I did a full test again, minus claim LP token, minus bridges (don't have enough funds and it costs a lot, will leave to ops)

One blocking comment thought, that we should tackle, I think doing a migration might be the proper solution as type-wise stakingContract is supposed to be defined in the TX

packages/contracts/src/constants.ts Outdated Show resolved Hide resolved
@gomesalexandre gomesalexandre self-requested a review January 15, 2025 19:54
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolute monster of a PR. Left a very few comments, but overall looks conceptually perf 🐐
Runtime test ongoing

Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally:

Misc

  • New dashboard is looking good (tested against develop - right)

image

WETH/FOX ARB LP ✅

RFOX stake flow e2e

https://jam.dev/c/f6934da5-5d26-47f8-83d5-51eb22f477d3

FOX ✅

Stake flow e2e regression test

https://jam.dev/c/39b34310-d113-4cba-9890-282894cc9ee6

Multi-account e2e (FOX and ETH/FOX LP) ✅

https://jam.dev/c/d7f6f8a9-24cc-4aa1-8fb1-45029e1704ca

@NeOMakinG NeOMakinG enabled auto-merge (squash) January 16, 2025 08:48
@NeOMakinG NeOMakinG merged commit a49edc7 into develop Jan 16, 2025
3 checks passed
@NeOMakinG NeOMakinG deleted the rfox-lpoors branch January 16, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rFOX for lpoors
4 participants