-
Notifications
You must be signed in to change notification settings - Fork 196
feat: grouped asset by primary asset #10380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NeOMakinG
wants to merge
28
commits into
develop
Choose a base branch
from
grouped-assets
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 26 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
0aaaee5
feat: grouped asset beginning
NeOMakinG 7844241
fix: review feedbacks
NeOMakinG daa36c4
Merge branch 'develop' into grouped-assets
NeOMakinG 716e0e8
feat: continue
NeOMakinG c1bc489
fix: review feedbacks
NeOMakinG 92e73f6
feat: finish but hey need cleanup ffs
NeOMakinG 3b1be2b
fix: review feedbacks
NeOMakinG 316e1af
fix: review feedbacks
NeOMakinG 538d83d
Merge branch 'develop' into grouped-assets
NeOMakinG c542870
chore: trigger ci
NeOMakinG 698bf99
fix: review feedbacks
NeOMakinG 4537aae
fix: review feedbacks
NeOMakinG 69ca5df
fix: more longpress
NeOMakinG e438d48
fix: review feedbacks
NeOMakinG 21e87eb
fix: fixes
NeOMakinG 6475820
fix: wip related assets base
NeOMakinG 13e68eb
fix: attempt at slices
NeOMakinG 157b534
fix: working ffs
NeOMakinG 046781c
fix: review feedbacks
NeOMakinG 3d9127c
fix: review feedbacks
NeOMakinG 2447eb5
fix: type check
NeOMakinG 4843ee6
fix: review feedbacks
NeOMakinG 8974452
chore: trigger ci
NeOMakinG e7280c7
fix: review feedbacks
NeOMakinG 5f61f6f
Merge branch 'develop' into grouped-assets
NeOMakinG 09cab7e
fix: review feedbacks
NeOMakinG fda4b3d
fix: tests
NeOMakinG 556bd19
fix: review feedbacks
NeOMakinG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,5 +49,7 @@ export const makeAsset = ( | |
color, | ||
icon, | ||
relatedAssetKey: null, | ||
isPrimary: true, | ||
isChainSpecific: true, | ||
}) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: wat dis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asset that is only one one chain, it's needed to discriminate as primary assets without related assets might have relatedAssetKey as null