Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to update OpenGEM7-RC3 with fixed Setup.BAT for Final Release #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Commander-Zal
Copy link

Hi Shane,

I wasn't able to get OpenGEM 6 or 7-RC3 to work properly on any of my machines running FreeDOS or DosBOX (many graphics and icons were missing). Went investigating, and found the comment from Michael Henry on the Gem-Dev mailing list with the revised setup.bat, which completely fixed my problem.

Having never used Github before, decided to try my hand at doing the fixes myself and submitting this pull request. Hopefully I did this right, let me know what you think! :)

Replaced broken setup batch script with fixed version from Michael Henry on the Gem-dev mailing list. http://www.simpits.org/pipermail/gem-dev/2017-July/001975.html

This allows OpenGEM to work correctly on both DosBOX and FreeDOS by allowing the setup tool to actually function and make changes to video drivers, etc.
Replaced broken setup batch script with fixed version from Michael Henry on the Gem-dev mailing list. http://www.simpits.org/pipermail/gem-dev/2017-July/001975.html

This allows OpenGEM to work correctly on both DosBOX and FreeDOS by allowing the setup tool to actually function and make changes to video drivers, etc.
Replaced broken setup.bat script with fixed version from Michael Henry on the Gem-dev mailing list. http://www.simpits.org/pipermail/gem-dev/2017-July/001975.html

This allows OpenGEM to work correctly on both DosBOX and FreeDOS by allowing the setup tool to function properly and make changes to video drivers, etc.
Updated with functioning Update.BAT file and updated README to reflect changes.
@xerz-one
Copy link

xerz-one commented Jul 6, 2018

Sadly, this isn't enough for me. I've installed OpenGEM 6 via the FreeDOS package manager and the scripts are just broken, it's a chaotic mix of wrong relative and absolute paths, which basically assumes that you've installed it all on C:\, whereas e.g. FreeDOS installs it by default on C:\FDOS\OPENGEM\.

Thank you for the PR though, that helped me debug the issue in my installation. Still not fixed though, looking into it.

@xerz-one
Copy link

xerz-one commented Jul 6, 2018

Oh, I see you've opened this ticket on Sourceforge... will wait to see what you come up with.

@Commander-Zal
Copy link
Author

@espectalll

Glad it was of some help :)

Just to confirm; after copying the files from my modified openGEM 7 folder to C:\openGEM on FreeDOS, and then using the setup tool to select an appropriate driver, it still displays strange behavior when you launch openGEM?

If so, does it display the same behavior on DOSBox?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants