Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Use original MCap if available on MCap polyfill #8039

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

perf: Use original MCap if available on MCap polyfill #8039

wants to merge 3 commits into from
+56 −15

Conversation

avelad
Copy link
Member

@avelad avelad commented Feb 7, 2025

No description provided.

@avelad avelad added the type: performance A performance issue label Feb 7, 2025
@avelad
Copy link
Member Author

avelad commented Feb 7, 2025

@shaka-bot test

@avelad avelad added this to the v4.14 milestone Feb 7, 2025
@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=8039

@joeyparrish
Copy link
Member

I don't understand this. If we want to use the original, there's a decision for that at the top of the polyfill.

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 68.42%

@avelad
Copy link
Member Author

avelad commented Feb 7, 2025

I don't understand this. If we want to use the original, there's a decision for that at the top of the polyfill.

We only want to use it in the case of media-source, not in the case of file. And we ignore the keySystemAccess response if there is one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: performance A performance issue
Projects
None yet
Milestone
v4.14
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @joeyparrish