-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring in Ondsel changes #335
base: master
Are you sure you want to change the base?
Conversation
GetViewConfig and SetViewConfig where copying over more stuff than they should in some situations bendwall's task panel could not unset greedy selection mode the behavior of baseshapecmd regarding Body creation was awkward and inconsistent with PartDesign commands, the command now knows when it needs to create a body or just use the an active one if it exists
App/Gui separation Parametric unfold object Added button for face selection in dialog remove sketch creation and export from unfold command, to be added back as a new separate command
Hello @adrianinsaval |
Hmmm I'll have to check which is the culript here. The SMSolidBend class still exists. But you're totally right |
Hello, In the new version of Ondsel, I cannot correctly open files containing sheet metal parts. It looks like this: |
@GS90, |
@shaise, |
@GS90, Thanks for this info, I'll try to contact them. |
I had misunderstood how restoring objects worked, it should be working now in this PR. I will see about making a bugfix release for ondsel within the next day |
ae9773f
to
2a9d281
Compare
@adrianinsaval, |
Increase version number
833f9ef
to
8605ca5
Compare
fixed
I can do this but I would like to have clear separation between app and gui sections of the code if possible, let me know |
@adrianinsaval , any updates? |
sorry for the delay, I've been dealing with some personal issues. I restored the previous file structure. I don't think this is an ideal structure (the inconsistent naming is confusing) but I can understand wanting to maintain full compatibility. We will ship something similar in a bugfix release of ondsel es but that has some proxies to migrate back files created with our previous release to this format. |
I did this on purpose to avoid unnecessarily wide dialogs and shortened words as these are often problematic for translations
I see this as desired behavior, accidentally deselecting everything due to a missclick would be a PITA. The idea is to emulate the behavior of PartDesign (see fillet/chamfer dialog). I do think that a quick way of deselecting everything is missing, I can work on that on the next iteration.
my interpretation was that these where warnings not errors and therefore shouldn't block the interface. My intention was to later migrate these to use the notification system as sketcher does nowadays. Let me check these more closely |
Great then. So actually only the last issue is important since it brakes part-design structure. |
Any news on this? |
I hate to see this 'die on the vine'... any chance of forward movement? |
If this is not resolved, I plan to cherry pick the changes and merge the important staff. But it will take time as I need to resolve important issues in CAM simulator |
Hi @shaise, this is entirely on me but unfortunately I didn't get to make the PRs I wanted in time and in smalls steps for all the changes I've been working on, sorry about that. This PR brings in all I did until now:
For now the unfold command is not doing export anymore as I considered that for a more consistent UX this should be left to the regular export command, I will start a discussion with the design working group about this and the projected sketches. Let me know what you think of this.
The PR is pretty big but a lot of it is just moving things around into separate files. Are you ok with the PR like this or do you want me to work on breaking it down in smaller chunks?
I will be more disciplined in the next development steps and make smaller easier to review PRs