fix: import VariantProps as a type-only import #8158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, VariantProps is imported as a value:
import { cva, VariantProps } from "class-variance-authority"
This causes a TypeScript error when `verbatimModuleSyntax` is enabled:
'VariantProps' is a type and must be imported using a type-only import
Since VariantProps is a type, it should be imported with `import type`:
import { cva, type VariantProps } from "class-variance-authority"
This fixes the type error in projects using TS 5.x strict module settings.
fix: import VariantProps as a type-only import
|
@yadhukrishnasm is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
VariantPropsis currently imported as a value:import { cva, VariantProps } from "class-variance-authority"
This causes a TypeScript error when
verbatimModuleSyntaxis enabled:'VariantProps' is a type and must be imported using a type-only import
Solution
Import
VariantPropsas a type:import { cva, type VariantProps } from "class-variance-authority"
Why
This resolves type errors in projects using TS 5.x strict module settings while preserving behavior in earlier TS versions.