fix: typescript error input & use-toast hook #5232
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5201
use-toast.ts
Error
here the error was
actionTypes
defined as const was only being used as a type inActionType
.Changes Made
actionTypes
in the reducer logic.actionTypes.ADD_TOAST
and so onOther Solution
actionTypes
completely by using the below structure fortype Action
input.tsx
Error
An interface declaring no members is equivalent to its supertype
Changes made
So the
InputProps
was extendingReact.InputHTMLAttributes<HTMLInputElement>
without adding any additional props. So have directly used the prop type without using an interfaceOther Solution
Let me know if there is a better way to do this