Provide more information about the RFC2229 and migration information #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
roxelo
commented
Jul 1, 2021
roxelo
commented
- Should I be linking to the rust reference instead? All the information in one place would make sense
- How much info is needed to be provided about migration?
- Should we be adding info about filling bugs and closure profiling here?
arora-aman
reviewed
Jul 1, 2021
| }); // Closure captured px.0 which is not Send | ||
| ``` | ||
|
|
||
| ## Capture Precision |
arora-aman
reviewed
Jul 1, 2021
| As for all edition changes, an automatic migration is available. | ||
| If you would like to be warned of semantics change that may impact your code, you can [use the lint](https://doc.rust-lang.org/rustc/lints/levels.html) `disjoint_capture_migrations`. The lint is also supported with [cargo fix](https://doc.rust-lang.org/cargo/commands/cargo-fix.html) to automatically migrate your code. | ||
|
|
||
| The migration fix involves adding `let _ = &a;`, where `a` is the variable that needs to be fully captures, inside the closure to force the entire |
There was a problem hiding this comment.
entire variable to be captured as before
arora-aman
reviewed
Jul 1, 2021
| If you would like to be warned of semantics change that may impact your code, you can [use the lint](https://doc.rust-lang.org/rustc/lints/levels.html) `disjoint_capture_migrations`. The lint is also supported with [cargo fix](https://doc.rust-lang.org/cargo/commands/cargo-fix.html) to automatically migrate your code. | ||
|
|
||
| The migration fix involves adding `let _ = &a;`, where `a` is the variable that needs to be fully captures, inside the closure to force the entire | ||
| struct to be captured as before. |
roxelo
force-pushed
the
rfc2229-info
branch
2 times, most recently
from
cee12c4
to
cbde8bb
Compare
Co-authored-by: Ryan Levick <[email protected]> Co-authored-by: Eric Huss <[email protected]>
updates to rfc2229 info Pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.