Skip to content

Conversation

@bvacaliuc
Copy link
Contributor

As requested, added tests for PR for #53

@coveralls
Copy link

coveralls commented Jun 29, 2018

Coverage Status

Coverage increased (+0.4%) to 79.609% when pulling c756cfe on bvacaliuc:tests_53 into ca13028 on sethoscope:master.

@sethoscope
Copy link
Owner

Hi, Bogdan. Thanks for adding the weight handling. Bonus points for writing a test case!
I notice the test data contains 2590 points. It seems like you could test this well with just three points (one negative, one small, one large), and it would be much easier to understand. As it is, I can't tell whether the test would fail if weights were ignored.

Any interest in trying that? If not, I can aim to get to it eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants