Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#142: catch StopIteration and return InvalidProductError #154

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

jteulade
Copy link
Contributor

Your checklist for this pull request

Please review the guidelines for contributing to this repository.

  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Description

Please describe your pull request.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Thank you!

@jteulade jteulade merged commit 8e001d0 into main Jun 10, 2024
2 checks passed
@jteulade jteulade deleted the 142-stopiteration-s2-product branch June 10, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant