Skip to content

Commit

Permalink
Fix typos
Browse files Browse the repository at this point in the history
  • Loading branch information
remi-braun committed Sep 23, 2024
1 parent 2e445ff commit 18d001a
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 20 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
run: |
if [ "$(./get_pypi_latest_version.sh)" != "$(python setup.py --version)" ]
then
echo "Current version is not on PyPI, proceed with bulding"
echo "Current version is not on PyPI, proceed with building"
else
echo "Current version is the latest version uploaded to PyPI"
exit 1
Expand Down
4 changes: 2 additions & 2 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@

- FIX: Fixing stack when saved as integer for some special cases
- FIX: Clipping negative reflectances to 0 ([#79](https://github.com/sertit/eoreader/issues/79))
- FIX: Fixing nodata mangement for Theia product
- FIX: Fixing nodata management for Theia product
- FIX: Fixing handling of SCS multi-swath `Cosmo-SkyMed` products ([#78](https://github.com/sertit/eoreader/issues/78))
- FIX: Writing spectral indices on disk to align with other bands ([#80](https://github.com/sertit/eoreader/issues/80))
- FIX: By default, calibration is not applied to slant range `CSG` data, avoiding producing an empty raster ([#48](https://github.com/sertit/eoreader/issues/48))
Expand All @@ -183,7 +183,7 @@

### Bug Fixes

- FIX: Fixing a bug for DIMAP V2 products whith GML masks opening without CRS: assigning first the raw CRS before converting to the product's CRS
- FIX: Fixing a bug for DIMAP V2 products with GML masks opening without CRS: assigning first the raw CRS before converting to the product's CRS
- FIX: Fixing index creation when exotic bands not handled by ASI have been loaded in the same time (i.e. stacking `NDWI` with `Oa21` band)

### Other
Expand Down
11 changes: 2 additions & 9 deletions CI/scripts_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,7 @@
import tempenv
from sertit import AnyPath, s3, unistra
from sertit.types import AnyPathType
from sertit.unistra import (
UNISTRA_S3_ENPOINT,
get_db2_path,
get_db3_path,
get_geodatastore,
)
from sertit.unistra import get_db2_path, get_db3_path, get_geodatastore

from eoreader import EOREADER_NAME
from eoreader.env_vars import TILE_SIZE
Expand Down Expand Up @@ -156,9 +151,7 @@ def broken_s2_path():


def s3_env(function):
return s3.s3_env(endpoint=UNISTRA_S3_ENPOINT, use_s3_env_var=CI_EOREADER_S3)(
function
)
return unistra.s3_env(use_s3_env_var=CI_EOREADER_S3)(function)


def compare(to_be_checked, ref, topic):
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ If this happens to you, do not hesitate to make a PR or write an issue about tha
## Talks

- [GeoPython 2022](https://submit.geopython.net/geopython-2022/talk/FQPN3Q/) [ [PDF](https://seafile.unistra.fr/f/be2b461af970465b903e/) ] [ [YouTube](https://www.youtube.com/watch?v=mKxOiRULOJA&t=14303s) ]
- Mentionned in **[Live+]SIG 2022 by ESRI France** (in French):
- Mentioned in **[Live+]SIG 2022 by ESRI France** (in French):
`Enrichir ArcgisPro grâce à des processus personnalisés d'observation de la Terre`
[ [PDF](https://seafile.unistra.fr/f/9502a14f142041468837/) ]
- Mentioned in GeoPython 2023 - `FLORIA, a custom python pipeline for urban flood extraction from SAR multi-sensors, supported by U-Net convolutional network.`
Expand Down
4 changes: 2 additions & 2 deletions docs/sar.md
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ The default pixel size of GRD bands is not the same as the product resolution! (

```{warning}
⚠ Pay attention that for a pixel spacing of 10 meters and a rg x az resolution of 23m, objects under 23m won't be resolved !
As this may be counter-intuitive, it is recommanded to **always** specify the pixel size when loading SAR data.
As this may be counter-intuitive, it is recommended to **always** specify the pixel size when loading SAR data.
```

```{note}
Expand Down Expand Up @@ -339,7 +339,7 @@ Those graphs should have a reader and a writer on this model:
Pay attention to set `$file` and `$out` and leave the `BEAM-DIMAP` file format. The first graph must orthorectify your
SAR data, but should not despeckle it. The second graph is precisely charged to do it.
SNAP graphs are run on every band separatly.
SNAP graphs are run on every band separately.
The pre-processing graph should also have a `Calibration` and a `Terrain Correction` step with the following wildcards that are set automatically in the module:
Expand Down
4 changes: 2 additions & 2 deletions eoreader/products/optical/planet_product.py
Original file line number Diff line number Diff line change
Expand Up @@ -285,15 +285,15 @@ def _merge_subdatasets(self) -> Tuple[AnyPathType, bool]:
if self.is_archived:
# VRT cannot be created from inside a ZIP
raise InvalidProductError(
"EOReader doens't handle archived Planet data with multiple subdataset. Please extract this product."
"EOReader doesn't handle archived Planet data with multiple subdataset. Please extract this product."
)
# TODO: merge_geotiff BUT handle reflectances for every subdataset!
# Relevant ? Maybe not as it takes would a lot of time to merge

if path.is_cloud_path(self.path):
# VRT cannot be created from data stored in the cloud
raise InvalidProductError(
"EOReader doens't handle cloud-stored Planet data with multiple subdataset. Please download this product on disk."
"EOReader doesn't handle cloud-stored Planet data with multiple subdataset. Please download this product on disk."
)
# Relevant ? Maybe not as it takes would a lot of time to download, or a lot of time to merge as geotiffs

Expand Down
2 changes: 1 addition & 1 deletion eoreader/products/product.py
Original file line number Diff line number Diff line change
Expand Up @@ -1613,7 +1613,7 @@ def _collocate_bands(bands: dict, reference: xr.DataArray = None) -> dict:
reference = band_arr
else:
# To be sure, always collocate arrays, even if the size is the same
# Indeed, a small difference in the coordinates will lead to empy arrays
# Indeed, a small difference in the coordinates will lead to empty arrays
# So the bands MUST BE exactly aligned
bands[band_id] = rasters.collocate(reference, band_arr)

Expand Down
4 changes: 2 additions & 2 deletions eoreader/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ def stack_dict(
bands: list, band_xds: xr.Dataset, save_as_int: bool, nodata: float, **kwargs
) -> (xr.DataArray, type):
"""
Stack a dictionnary containing bands in a DataArray
Stack a dictionary containing bands in a DataArray
Args:
bands (list): List of bands (to keep the right order of the stack)
Expand All @@ -396,7 +396,7 @@ def stack(
band_xds: xr.Dataset, save_as_int: bool, nodata: float, **kwargs
) -> (xr.DataArray, type):
"""
Stack a dictionnary containing bands in a DataArray
Stack a dictionary containing bands in a DataArray
Args:
band_xds (xr.Dataset): Dataset containing the bands
Expand Down

0 comments on commit 18d001a

Please sign in to comment.