asusd: Add at v6.1.0-rc2 #446
Conversation
|
You need to fix the homepage in the stone.yaml |
Thanks yeah, is draft - I'm actively working on asusd itself to fix a few issues too. |
flukejones
force-pushed
the
asusd
branch
2 times, most recently
from
6c2f8b3 to
a78c726
Compare
There was a problem hiding this comment.
I was going to leave specific comments here, but honestly I'm very confused by this build.
- Why is it specifying
toolchain: gnu, does it not build with Clang? - Is mold a build requirement or is it just because it shaves a bit of time off the build? (hint: if I'm asking this question it's because there should be a comment in the recipe explaining the choice)
- Why is it pulling in
cmakewhen it appears to usemake?
|
Oh okay I just realized that you copied and pasted what was in the zed recipe. Feel free to ping me when you want this to actually be reviewed then. |
|
@ReillyBrogan I think I've addressed everything now. It might be an RC but it's in a good position to be included now - and there will be more work coming but no timeframe so RC is better than none at present. |
flukejones
force-pushed
the
asusd
branch
2 times, most recently
from
d7b8364 to
8d7f70d
Compare
|
I think that was a good clean up. Build tested, install tested, run tested. |
There was a problem hiding this comment.
Looks much better now! The only thing that needs to be fixed is that some changes to the linux desktop manifest seem to have snuck in during a rebase/amend.
Once that's done I'll approve this, but if you want since you need to poke it anyway you could move the comment about installing data/bins into the install block itself. The other minor thing you could change is to change
license :
- MPL-2.0
To
license : MPL-2.0
Neither of these changes require a rebuild.
The final optional thing you could do would be to pre-enable the services out of the box (if that's desirable to users).
If you want to do that then create two files asusd.preset and asusd-user.preset in the pkgdir with the following contents respectively:
enable asusd.service
and
enable asusd-user.service
And then install these to %(installroot)%(libdir)/systemd/system-preset/50-asusd.preset and %(installroot)%(libdir)/systemd/user-preset/50-asusd-user.preset. Then they'll be enabled by default by a trigger.
Ignore if the services are DBUS-activated instead.
|
The services are udev rule activated. But it would be handy to be able to start them on install |
Add asusd laptop control daemon for ASUS laptops. Signed-off-by: Luke D. Jones <[email protected]>
Signed-off-by: Ikey Doherty <[email protected]>
Add asusd laptop control daemon for ASUS laptops.