Add wait_keyframe feature in the record module #274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the record module with a low record_interval (1 minute).
When I try to merge the segment files, the video stutters because the segment files have no video frame before the first key frame, and the first key frame can only appear after a few seconds.
This pull request provides an option "record_wait_keyframe"; when enabled, the next segment file always starts with a keyframe.
Tested with nginx 1.13.8, and behaviour verified with
ffprobe -show_frames
.First video frame in a segment file with record_wait_keyframe disabled:
First video frame in a segment file with record_wait_keyframe enabled: