Improvement: check image exists first #1334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done
With this PR, image existence checking has been added in
recognition.py
. The reason for this change is to solve the situtation that occurs when attempting to find similar faces using thefind
function. Previously, the function first collected embeddings from the database before searching for faces in the target image. If the path to the target image was incorrect or the image did not exist, the exception would only be raised after the database scan, which could be time-consuming.How to test