add f16 and f128 support #2941
add f16 and f128 support #2941
Conversation
serde/src/de/mod.rs
Outdated
| @@ -1439,6 +1463,17 @@ pub trait Visitor<'de>: Sized { | |||
| )) | |||
| } | |||
|
|
|||
| /// The input contains a `f16`. | |||
| /// | |||
| /// The default implementation forwards to visit_f64. | |||
There was a problem hiding this comment.
Like the others:
| /// The default implementation forwards to visit_f64. | |
| /// The default implementation forwards to [`visit_f64`]. |
There was a problem hiding this comment.
this break documentation build sadly
There was a problem hiding this comment.
You'll need to add something like:
[`visit_f64`]: #method.visit_f64at the bottom of the doc comment.
There was a problem hiding this comment.
Very strange, that documentation is broken, it should be broken in other places as well. The correct link should be
[`visit_f64`](Self::visit_f64)
There was a problem hiding this comment.
I think either way should work. You can see that it does link correctly on docs.rs for the other links for this trait. For example: https://docs.rs/serde/latest/serde/de/trait.Visitor.html#method.visit_u64
There was a problem hiding this comment.
Of course, just intralinks can be checked by the compiler
Co-authored-by: Mingun <[email protected]>
Co-authored-by: Mingun <[email protected]>
|
@Vrtgs Any news for this? |
add initial support for f16 and f128, next steps are to add this support in serde_test if this lands
helps with adding ecosystem support par in rust-lang/rust#116909