-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean the Monero lib for auditing #577
Commits on Jul 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 98b08ea - Browse repository at this point
Copy the full SHA 98b08eaView commit details -
Rename Bulletproofs to Bulletproof, since they are a single Bulletproof
Also bifurcates prove with prove_plus, and adds a few documentation items.
Configuration menu - View commit details
-
Copy full SHA for f5d9d03 - Browse repository at this point
Copy the full SHA f5d9d03View commit details -
Also adds a bit more documentation and does a bit more tidying.
Configuration menu - View commit details
-
Copy full SHA for cd8b054 - Browse repository at this point
Copy the full SHA cd8b054View commit details -
It's a notable bandwidth/performance improvement, yet it's not ready. We need a dedicated Distribution struct which is managed by the wallet and passed in. While we can do that now, it's not currently worth the effort.
Configuration menu - View commit details
-
Copy full SHA for f1ad768 - Browse repository at this point
Copy the full SHA f1ad768View commit details -
Configuration menu - View commit details
-
Copy full SHA for c165c36 - Browse repository at this point
Copy the full SHA c165c36View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2a27dc - Browse repository at this point
Copy the full SHA d2a27dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1d1de0 - Browse repository at this point
Copy the full SHA a1d1de0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cdae6e - Browse repository at this point
Copy the full SHA 5cdae6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 784a273 - Browse repository at this point
Copy the full SHA 784a273View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c21791 - Browse repository at this point
Copy the full SHA 9c21791View commit details -
Configuration menu - View commit details
-
Copy full SHA for 865dee8 - Browse repository at this point
Copy the full SHA 865dee8View commit details -
Add a dedicated send/recv CLSAG mask struct
Abstracts the types used internally. Also moves the tests from monero-serai to monero-clsag.
Configuration menu - View commit details
-
Copy full SHA for 798ffc9 - Browse repository at this point
Copy the full SHA 798ffc9View commit details -
Removes usage of dalek-ff-group/multiexp for curve25519-dalek. Makes compiling in the generators an optional feature. Adds a structured batch verifier which should be notably more performant. Documentation and clean up still necessary.
Configuration menu - View commit details
-
Copy full SHA for f7c13fd - Browse repository at this point
Copy the full SHA f7c13fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9107b5 - Browse repository at this point
Copy the full SHA d9107b5View commit details -
Tidy and document monero-bulletproofs
I still don't like the impl of the original Bulletproofs...
Configuration menu - View commit details
-
Copy full SHA for 77a2496 - Browse repository at this point
Copy the full SHA 77a2496View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60d5c06 - Browse repository at this point
Copy the full SHA 60d5c06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 303e72c - Browse repository at this point
Copy the full SHA 303e72cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e82ee6 - Browse repository at this point
Copy the full SHA 3e82ee6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a1c6c7 - Browse repository at this point
Copy the full SHA 3a1c6c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d740bd2 - Browse repository at this point
Copy the full SHA d740bd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08b95ab - Browse repository at this point
Copy the full SHA 08b95abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f61861 - Browse repository at this point
Copy the full SHA 6f61861View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5b9d4a - Browse repository at this point
Copy the full SHA b5b9d4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1db4091 - Browse repository at this point
Copy the full SHA 1db4091View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74aaac4 - Browse repository at this point
Copy the full SHA 74aaac4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fc8b30 - Browse repository at this point
Copy the full SHA 6fc8b30View commit details -
Only read transactions with one Input::Gen or all Input::ToKey
Also adds a helper to fetch a transaction's prefix.
Configuration menu - View commit details
-
Copy full SHA for df095f0 - Browse repository at this point
Copy the full SHA df095f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e2e3bd - Browse repository at this point
Copy the full SHA 1e2e3bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11dba91 - Browse repository at this point
Copy the full SHA 11dba91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b20004 - Browse repository at this point
Copy the full SHA 0b20004View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb0c19b - Browse repository at this point
Copy the full SHA eb0c19bView commit details -
Credit to @hinto-janai for adding such sections to their work on documenting monero-serai in #568.
Configuration menu - View commit details
-
Copy full SHA for 0f47753 - Browse repository at this point
Copy the full SHA 0f47753View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3b0edb - Browse repository at this point
Copy the full SHA b3b0edbView commit details -
Rewrite monero-wallet's send code
I have yet to redo the multisig code and the builder. This should be much cleaner, albeit slower due to redoing work. This compiles with clippy --all-features. I have to finish the multisig/builder for --all-targets to work (and start updating the rest of Serai).
Configuration menu - View commit details
-
Copy full SHA for 70c36ed - Browse repository at this point
Copy the full SHA 70c36edView commit details -
Configuration menu - View commit details
-
Copy full SHA for abd48e9 - Browse repository at this point
Copy the full SHA abd48e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08d604f - Browse repository at this point
Copy the full SHA 08d604fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 891362a - Browse repository at this point
Copy the full SHA 891362aView commit details -
Update monero-wallet tests to compile
Some are _consistently_ failing due to the inputs we attempt to spend being too young. I'm unsure what's up with that. Most seem to pass _consistently_, implying it's not a random issue yet some configuration/env aspect.
Configuration menu - View commit details
-
Copy full SHA for 8319d21 - Browse repository at this point
Copy the full SHA 8319d21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69e077b - Browse repository at this point
Copy the full SHA 69e077bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0624661 - Browse repository at this point
Copy the full SHA 0624661View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64e74c5 - Browse repository at this point
Copy the full SHA 64e74c5View commit details -
Diversify ViewPair/Scanner into ViewPair/GuaranteedViewPair and Scann…
…er/GuaranteedScanner Also cleans the Scanner impl.
Configuration menu - View commit details
-
Copy full SHA for daa0f8f - Browse repository at this point
Copy the full SHA daa0f8fView commit details -
Remove non-small-order view key bound
Guaranteed addresses are in fact guaranteed even with this due to prefixing key images causing zeroing the ECDH to not zero the shared key.
Configuration menu - View commit details
-
Copy full SHA for b56c6fb - Browse repository at this point
Copy the full SHA b56c6fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08169e2 - Browse repository at this point
Copy the full SHA 08169e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3de89c7 - Browse repository at this point
Copy the full SHA 3de89c7View commit details -
Remove possible panic in monero-serai on systems < 32 bits
This was done by requiring the system's usize can represent a certain number.
Configuration menu - View commit details
-
Copy full SHA for 0f9a5af - Browse repository at this point
Copy the full SHA 0f9a5afView commit details -
Configuration menu - View commit details
-
Copy full SHA for e94a04d - Browse repository at this point
Copy the full SHA e94a04dView commit details
Commits on Jul 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 90880cc - Browse repository at this point
Copy the full SHA 90880ccView commit details
Commits on Jul 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1f5e5fc - Browse repository at this point
Copy the full SHA 1f5e5fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04df229 - Browse repository at this point
Copy the full SHA 04df229View commit details -
Fix a pair of bugs in the decoy tests
Unfortunately, this test is still failing.
Configuration menu - View commit details
-
Copy full SHA for 788c4fc - Browse repository at this point
Copy the full SHA 788c4fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2c962c - Browse repository at this point
Copy the full SHA b2c962cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d847ec5 - Browse repository at this point
Copy the full SHA d847ec5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0631607 - Browse repository at this point
Copy the full SHA 0631607View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2334725 - Browse repository at this point
Copy the full SHA 2334725View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6357bc0 - Browse repository at this point
Copy the full SHA 6357bc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f7dbf2 - Browse repository at this point
Copy the full SHA 9f7dbf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c138950 - Browse repository at this point
Copy the full SHA c138950View commit details
Commits on Jul 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3cf0b84 - Browse repository at this point
Copy the full SHA 3cf0b84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4743ea7 - Browse repository at this point
Copy the full SHA 4743ea7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d99ed96 - Browse repository at this point
Copy the full SHA d99ed96View commit details -
Correct the if check about when to mine blocks on start
Finally fixes the lack of decoy candidates failures in CI.
Configuration menu - View commit details
-
Copy full SHA for 86facae - Browse repository at this point
Copy the full SHA 86facaeView commit details -
Run Monero on Debian, even for internal testnets
Change made due to a segfault incurred when locally testing. monero-project/monero#9141 for the upstream.
Configuration menu - View commit details
-
Copy full SHA for c521bbb - Browse repository at this point
Copy the full SHA c521bbbView commit details -
Don't attempt running tests on the verify-chain binary
Adds a minimum XMR fee to the processor and runs fmt.
Configuration menu - View commit details
-
Copy full SHA for 1bfd7d9 - Browse repository at this point
Copy the full SHA 1bfd7d9View commit details -
Increase minimum Monero fee in processor
I'm truly unsure why this is required right now.
Configuration menu - View commit details
-
Copy full SHA for 9e4d83b - Browse repository at this point
Copy the full SHA 9e4d83bView commit details -
Distinguish fee from necessary_fee in monero-wallet
If there's no change, the fee is difference of the inputs to the outputs. The prior code wouldn't check that amount is greater than or equal to the necessary fee, and returning the would-be change amount as the fee isn't necessarily helpful. Now the fee is validated in such cases and the necessary fee is returned, enabling operating off of that.
Configuration menu - View commit details
-
Copy full SHA for d88bd70 - Browse repository at this point
Copy the full SHA d88bd70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6994d93 - Browse repository at this point
Copy the full SHA 6994d93View commit details