New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement genesis liquidity protocol #545

Merged

kayabaNerve merged 25 commits into serai-dex:develop from akildemir:emissions

Jul 18, 2024

Contributor

akildemir commented Mar 27, 2024

No description provided.

akildemir and others added 19 commits

March 27, 2024 14:46


          add genesis liquidity implementation

c1bcb0f


          Merge branch 'develop' of https://github.com/serai-dex/serai into emi…

da51543

…ssions


          add missing deposit event

b9df73e


          fix CI issues

2b32fe9


          minor fixes

207f2bd


          make math safer

c320402


          fix fmt

8be0538


          Merge branch 'develop' of https://github.com/serai-dex/serai into emi…

df774d1

…ssions


          make remove liquidity an authorized call

7041dbe


          implement setting initial values for coins

826f998


          add genesis liquidity test & misc fixes

926ddd0


          Merge branch 'develop' of https://github.com/serai-dex/serai into emi…

7ecbfde

…ssions


          updato develop latest

20cf4c9


          Merge branch 'develop' of https://github.com/serai-dex/serai into emi…

90a5232

…ssions


          fix rotation test

04fcb2b


          Merge branch 'develop' of https://github.com/akildemir/serai into emi…

929d0bf

…ssions


          Merge branch 'develop' into HEAD

ad70bce


          Finish merging develop

28edc66


          Remove accidentally committed ETH files

f75fe67

kayabaNerve reviewed

View reviewed changes

Member

kayabaNerve left a comment

Initial review for now. I have yet to read over the test. Mainly concerned about algorithmic complexity for the genesis distribution.

substrate/abi/src/genesis_liquidity.rs Outdated Show resolved Hide resolved

substrate/abi/src/genesis_liquidity.rs Show resolved Hide resolved

substrate/abi/src/liquidity_tokens.rs Show resolved Hide resolved

substrate/abi/src/genesis_liquidity.rs Show resolved Hide resolved

substrate/client/src/serai/dex.rs Outdated Show resolved Hide resolved

substrate/genesis-liquidity/pallet/src/lib.rs Outdated Show resolved Hide resolved

substrate/genesis-liquidity/pallet/src/lib.rs Outdated Show resolved Hide resolved

substrate/genesis-liquidity/pallet/src/lib.rs Show resolved Hide resolved

substrate/genesis-liquidity/pallet/src/lib.rs Outdated Show resolved Hide resolved

substrate/genesis-liquidity/pallet/src/lib.rs Outdated Show resolved Hide resolved

akildemir added 2 commits

June 28, 2024 16:17


          fix pr comments

c14923f


          further bug fixes

ef70384

kayabaNerve reviewed

View reviewed changes

substrate/genesis-liquidity/pallet/src/lib.rs Show resolved Hide resolved

substrate/genesis-liquidity/pallet/src/lib.rs Outdated Show resolved Hide resolved

substrate/genesis-liquidity/pallet/src/lib.rs Outdated Show resolved Hide resolved

substrate/genesis-liquidity/pallet/src/lib.rs Outdated Show resolved Hide resolved

substrate/genesis-liquidity/pallet/src/lib.rs Outdated

+                        };
+                        total_sri_distributed += sri_amount;
+                        // we can't add 0 liquidity

Member

kayabaNerve Jul 3, 2024

Isn't there actually a minimum in the DEX pallet for the initial liq? 10 or 50k atomic units?

Contributor Author

akildemir Jul 4, 2024

yea but it is for liquidity tokens that the pallet handles itself. Only 0 check is being done on the actual coins being added.

Member

kayabaNerve Jul 17, 2024

https://github.com/serai-dex/serai/blob/develop/substrate/dex/pallet/src/lib.rs#L608-L623

https://github.com/serai-dex/serai/blob/develop/substrate/runtime/src/lib.rs#L231

substrate/genesis-liquidity/pallet/src/lib.rs Show resolved Hide resolved

substrate/genesis-liquidity/pallet/src/lib.rs Outdated Show resolved Hide resolved

substrate/genesis-liquidity/pallet/src/lib.rs Outdated Show resolved Hide resolved

substrate/genesis-liquidity/pallet/src/lib.rs Outdated Show resolved Hide resolved


          fix last pr comments

1eee0a4

akildemir force-pushed the emissions branch from 84dbcae to 1eee0a4 Compare

July 11, 2024 08:56

kayabaNerve reviewed

View reviewed changes

substrate/genesis-liquidity/primitives/src/lib.rs Outdated Show resolved Hide resolved

substrate/genesis-liquidity/primitives/src/lib.rs Outdated Show resolved Hide resolved

substrate/genesis-liquidity/primitives/src/lib.rs Outdated Show resolved Hide resolved

substrate/client/tests/genesis_liquidity.rs Outdated Show resolved Hide resolved

substrate/client/tests/genesis_liquidity.rs Outdated Show resolved Hide resolved

substrate/client/tests/genesis_liquidity.rs Show resolved Hide resolved

substrate/client/tests/genesis_liquidity.rs Outdated Show resolved Hide resolved

substrate/genesis-liquidity/pallet/src/lib.rs

+                use primitives::*;
+                /// LiquidityTokens Pallet as an instance of coins pallet.
+                pub type LiquidityTokens<T> = coins_pallet::Pallet<T, coins_pallet::Instance1>;

Member

kayabaNerve Jul 17, 2024

Can we at least add a TODO to revisit this then please? It's not fundamentally unacceptable yet we need to be working towards robust solutions.

substrate/genesis-liquidity/pallet/src/lib.rs Outdated

+                        };
+                        total_sri_distributed += sri_amount;
+                        // we can't add 0 liquidity

Member

kayabaNerve Jul 17, 2024

https://github.com/serai-dex/serai/blob/develop/substrate/dex/pallet/src/lib.rs#L608-L623

https://github.com/serai-dex/serai/blob/develop/substrate/runtime/src/lib.rs#L231

substrate/genesis-liquidity/pallet/src/lib.rs Outdated Show resolved Hide resolved

akildemir and others added 3 commits

July 18, 2024 16:35


          tidy up

9d50fe7


          Merge branch 'develop' into HEAD


          Misc

b040dce

Member

kayabaNerve commented Jul 18, 2024

Processor CI hung, unrelated.

kayabaNerve merged commit 1493f49 into serai-dex:develop

11 of 12 checks passed

kayabaNerve added feature runtime labels

akildemir deleted the emissions branch

July 19, 2024 08:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature runtime