Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "can not convert object to primitive" nonsence error message #697

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

secam
Copy link

@secam secam commented Feb 1, 2025

MikroOrm that uses umzug under the hood, throws custom errors in the form of objects derived from null (Null prototype objects) that are not handled correctly by errorString method, this result in confusing error message masking original error completely (nothing related to original error in stack trace)
This micro fix solves this and makes errorString more universal in handling such tricky objects.

Copy link

pkg-pr-new bot commented Feb 2, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/sequelize/umzug@697

commit: 0715f1f

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (7dc3877) to head (0715f1f).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #697   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          12       12           
  Lines        1466     1473    +7     
  Branches      269      269           
=======================================
+ Hits         1458     1465    +7     
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/umzug.test.ts Outdated Show resolved Hide resolved
src/umzug.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants