Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set frame_id to status message #180

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Dec 5, 2024

No description provided.

@at-wat at-wat self-assigned this Dec 5, 2024
@sqbot

This comment has been minimized.

@sqbot
Copy link
Member

sqbot commented Dec 5, 2024

[354] FAILED on noetic

Test failed
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_state_estimator.xml: 12 tests
build/test_results/urg_stamped/gtest-test_param.xml: 12 tests
build/test_results/urg_stamped/gtest-test_scip2.xml: 2 tests
build/test_results/urg_stamped/gtest-test_strings.xml: 2 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
build/test_results/urg_stamped/rostest-test_tests_e2e.xml: 1 tests
build/test_results/urg_stamped/rostest-test_tests_sync_timing.xml: 1 tests
build/test_results/urg_stamped/rosunit-e2e.xml: 20 tests, 0 errors, 2 failures, 0 skipped
build/test_results/urg_stamped/rosunit-sync_timing.xml: 2 tests
Summary: 61 tests, 0 errors, 2 failures, 0 skipped

[354] PASSED on noetic

All tests passed
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_state_estimator.xml: 12 tests
build/test_results/urg_stamped/gtest-test_param.xml: 12 tests
build/test_results/urg_stamped/gtest-test_scip2.xml: 2 tests
build/test_results/urg_stamped/gtest-test_strings.xml: 2 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
build/test_results/urg_stamped/rostest-test_tests_e2e.xml: 1 tests
build/test_results/urg_stamped/rostest-test_tests_sync_timing.xml: 1 tests
build/test_results/urg_stamped/rosunit-e2e.xml: 20 tests
build/test_results/urg_stamped/rosunit-sync_timing.xml: 2 tests
Summary: 61 tests, 0 errors, 0 failures, 0 skipped

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.97%. Comparing base (fe8fca5) to head (f28e66c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   84.22%   83.97%   -0.25%     
==========================================
  Files          36       36              
  Lines        1559     1560       +1     
==========================================
- Hits         1313     1310       -3     
- Misses        246      250       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@at-wat at-wat requested a review from f-fl0 December 5, 2024 07:40
Copy link
Contributor

@f-fl0 f-fl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit fa1e734 into master Dec 6, 2024
5 checks passed
@at-wat at-wat deleted the set-frame-id-to-status-message branch December 6, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants