Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support UUST2 with fixed firmware #177

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Support UUST2 with fixed firmware #177

merged 6 commits into from
Nov 25, 2024

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Nov 8, 2024

Also fix TM command retry timing as new UUST2 takes long delay when TM0 command is sent multiple times and causes watchdog timeout.

@at-wat at-wat self-assigned this Nov 8, 2024
@sqbot

This comment has been minimized.

@sqbot

This comment has been minimized.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.45%. Comparing base (78ae364) to head (47559c0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/urg_stamped.cpp 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   83.58%   83.45%   -0.14%     
==========================================
  Files          34       36       +2     
  Lines        1547     1559      +12     
==========================================
+ Hits         1293     1301       +8     
- Misses        254      258       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sqbot

This comment has been minimized.

@sqbot
Copy link
Member

sqbot commented Nov 8, 2024

[350] PASSED on noetic

All tests passed
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_state_estimator.xml: 12 tests
build/test_results/urg_stamped/gtest-test_param.xml: 12 tests
build/test_results/urg_stamped/gtest-test_scip2.xml: 2 tests
build/test_results/urg_stamped/gtest-test_strings.xml: 2 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
build/test_results/urg_stamped/rostest-test_tests_e2e.xml: 1 tests
build/test_results/urg_stamped/rostest-test_tests_sync_timing.xml: 1 tests
build/test_results/urg_stamped/rosunit-e2e.xml: 20 tests
build/test_results/urg_stamped/rosunit-sync_timing.xml: 2 tests
Summary: 61 tests, 0 errors, 0 failures, 0 skipped

@at-wat at-wat marked this pull request as ready for review November 22, 2024 09:27
@at-wat at-wat requested review from Taka-Kazu and f-fl0 November 22, 2024 09:30
Copy link
Contributor

@f-fl0 f-fl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit fe8fca5 into master Nov 25, 2024
5 checks passed
@at-wat at-wat deleted the support-fixed-uust2 branch November 25, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants