Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backport for geographiclib #634

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add backport for geographiclib #634

wants to merge 1 commit into from

Conversation

f-fl0
Copy link
Contributor

@f-fl0 f-fl0 commented Feb 26, 2022

@f-fl0 f-fl0 force-pushed the add-geographiclib branch from dbdefc4 to 6931d2a Compare February 26, 2022 02:57
@f-fl0 f-fl0 marked this pull request as ready for review February 26, 2022 03:06
@f-fl0 f-fl0 requested a review from at-wat February 26, 2022 03:06
Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

geographiclib seems containing both libraries and tools.
It would be better to split tools package from libraries package.
(On ubuntu, there seems be libgeographic17 and geographiclib-tools)

@f-fl0
Copy link
Contributor Author

f-fl0 commented Apr 29, 2022

I would like to confirm I understood your comment correctly: you are suggesting to create a separate APKBUILD file in a geographiclib-tools folder that will compile and install only the tools from geographiclib. Is it correct?

I'm not sure what is the best way to split the library and the tools. Looking at the CMakeLists.txt file, it does not seem possible to skip the tools folder and also not possible to compile the tools folder content without the rest. With minor modifications i.e. commenting out these lines https://github.com/geographiclib/geographiclib/blob/920702bc36ea13c384686556f25fb6369141a8e1/CMakeLists.txt#L470-L474, the tools folder can be skipped during compilation thus we can install the libraries without the tools.
Unfortunately, it would require much more changes to CMakeLists.txt to be able to compile only the content of the tools folder. Another way would be to compile the whole thing in both geographiclib and geographiclib-tools but only copy what is relevant in /usr.

What do you think?

@at-wat
Copy link
Member

at-wat commented May 2, 2022

I would like to confirm I understood your comment correctly: you are suggesting to create a separate APKBUILD file in a geographiclib-tools folder that will compile and install only the tools from geographiclib. Is it correct?

APKBUILD can generate multiple subpackages from single source.
See: https://wiki.alpinelinux.org/wiki/Creating_an_Alpine_package#subpackages
Example: https://github.com/seqsense/aports-ros-experimental/blob/master/backports/gtest/APKBUILD

@f-fl0
Copy link
Contributor Author

f-fl0 commented May 2, 2022

Thank you for the links. I will look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants