-
Notifications
You must be signed in to change notification settings - Fork 9
Fix: scan and mirror enabled flag bug #935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Member
Author
|
tested locally (scan and mirror is disabled): |
Member
Author
Member
Author
|
Tested on dev (scan and mirror is disabled): |
This reverts commit 8812a12.
Signed-off-by: munishchouhan <[email protected]>
pditommaso
reviewed
Nov 26, 2025
src/main/groovy/io/seqera/wave/service/cleanup/CleanupServiceImpl.groovy
Show resolved
Hide resolved
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
pditommaso
approved these changes
Nov 26, 2025
Collaborator
|
May be related #936 |
Member
Author
No I reproduced the bug with wave.scan.enabled=false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Summary
This PR fixes critical dependency injection issues in
Wave Lite mode and includes documentation improvements:
These fixes ensure Wave can run properly without scan/mirror features enabled by preventing bean instantiation failures and null pointer exceptions.
Test plan