-
Notifications
You must be signed in to change notification settings - Fork 9
Add support for build templates (and pixi) #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
ff336a8 to
413d730
Compare
Signed-off-by: Paolo Di Tommaso <[email protected]>
This was referenced May 18, 2025
ewels
reviewed
May 27, 2025
Co-authored-by: Phil Ewels <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Paolo Di Tommaso <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: munishchouhan <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Clarify that the tar utility requirement for conda/pixi/v1 and conda/micromamba/v2 templates only applies to Singularity builds. This is due to proot limitations in Singularity multi-stage builds which cannot copy directory structures directly between stages. Updated documentation in: - ADR: Added explanation of proot limitation - API docs: Clarified Singularity-only requirement - CLI docs: Added Singularity build requirements section 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Update template identifiers to use colon before version: - conda/pixi/v1 -> conda/pixi:v1 - conda/micromamba/v1 -> conda/micromamba:v1 - conda/micromamba/v2 -> conda/micromamba:v2 - cran/installr/v1 -> cran/installr:v1 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Collaborator
Author
|
Ready ✅ |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces support for multi-stage build templates (Pixi and Micromamba v2), updates libseqera dependencies, and includes various documentation improvements and bug fixes.
Key Changes
Build Template Support
Added
buildTemplateparameter to support new container build strategies:conda/micromamba:v1conda/micromamba:v2conda/pixi:v1cran/installr:v1Multi-stage templates (
conda/micromamba:v2andconda/pixi:v1) create optimized container images by separating the build environment from the final runtime environment, resulting in smaller container images that only contain installed packages and runtime dependencies.Documentation
docs/api.mdAPI Changes
New fields added to the container provisioning API (
/v1alpha2/container):buildTemplateconda/pixi:v1,conda/micromamba:v2,cran/installr:v1pixiOptsconda/pixi:v1template)pixiOpts.pixiImageghcr.io/prefix-dev/pixi:0.59.0-noble)pixiOpts.baseImageubuntu:24.04)pixiOpts.basePackagespixiOpts.commandsImplementation Details
ContainerHelper:containerFileFromRequest()- Routes to appropriate template based onbuildTemplateparameterDockerHelper:condaFileToDockerFileUsingPixi()condaFileToSingularityFileUsingPixi()condaFileToDockerFileUsingMicromamba()condaFileToSingularityFileUsingMicromamba()Test Plan
./gradlew test./gradlew jibDockerBuild