-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for lyrics #519
base: master
Are you sure you want to change the base?
Conversation
thanks for work here, but is this a dupe of #488 ? |
Not exactly a dupe since I've added also the possibility of fetching the lyrics from the embedded tag. Since i couldn't work on that pull request I've decided to make a new one. I should have implemented all things that weren't implemented on the other pull request |
How can i test it? I can't understand how to build it |
Hi, I suggest to build a custom docker image and use that in your
These are the steps needed to build and use the image, but i have noticed that it returns an error. The problem is the one fixed by #526. Changing the Dockerfile with the changes proposed by #526 fixes the issue and let you build the image. |
That's works. Thank you! |
Any updates? Will this get merged? |
The feature works fine, I've been using it for a few months without any problems. We should wait for a response from @sentriz |
In this pull request I've added support for lyrics.
When we make a scan now we check for lyrics inside the file using
taglib
, once the scan process in finished we have all lyrics saved on the db so we can retrieve them faster. When we are looking for a lyrics it first checks if there is a embedded lyric, if there is we return that, otherwise it looks for a fileSONG_NAME.lrc
and reads the lyrics from it. If there isn't a.lrc
file an empty response is provided.I've added support for both
getLyrics
andgetLyricsBySongId
methods. I have even created a migration, but i'm not so sure if that works fine maybe give that a double check.Let me know if there is something to change.
P.S. I have used some code from #488