Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest BaseInterface under sendgrid namespace #487

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adibsaad
Copy link

@adibsaad adibsaad commented Jul 4, 2022

Fixes

The constant "BaseInterface" is used by my app, and when I upgraded Sendgrid to the latest version, it resulted in conflicts.
I figured the word "BaseInterface" is generic enough that it's used by many people and can lead to hard-to-find bugs, so I'm suggesting moving BaseInterface to SendGrid::BaseInterface

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant